Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove 100Rnd mags magwell from non MX-SW MX variants #1058

Merged
merged 2 commits into from
Feb 9, 2019
Merged

remove 100Rnd mags magwell from non MX-SW MX variants #1058

merged 2 commits into from
Feb 9, 2019

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Feb 9, 2019 •
edited
Loading

When merged this pull request will:

Reasons can be found here: #1050
Don't fret, below is linked a PR for ACE that re-introduces the big magazines for all other MX variants.

@commy2 commy2 added the Bug Fix label Feb 9, 2019
@commy2 commy2 added this to the 3.10 milestone Feb 9, 2019
@commy2 commy2 mentioned this pull request Feb 9, 2019
Merged
@dedmen
Copy link
Contributor

dedmen commented Feb 9, 2019

But shouldn't we also re-add it to the MX SW variants? They do support 100rnd

@commy2
Copy link
Contributor Author

commy2 commented Feb 9, 2019 •
edited
Loading

That's what these lines do:

    class arifle_MX_SW_F: arifle_MX_Base_F {
        magazineWell[] = {"CBA_65x39_MX", "CBA_65x39_MX_XL"};
    };

@dedmen
Copy link
Contributor

dedmen commented Feb 9, 2019

nevermind my blindness

@commy2 commy2 merged commit 61dd332 into master Feb 9, 2019
@commy2 commy2 deleted the 100Rnd-mags-for-MXSW-only branch February 9, 2019 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonpas jonpas jonpas approved these changes

@dedmen dedmen dedmen approved these changes

Assignees
No one assigned
Labels
Bug Fix
Projects
None yet
Milestone
3.10
Development

Successfully merging this pull request may close these issues.

Magwells seem to give players an unfair advantage on a MP Server
3 participants
@commy2 @dedmen @jonpas